linux-kernel - Re: [PATCH] omapfb: dss: Fix max fclk divider for omap36xx

Open Source and information security mailing list archives

Date:   Fri, 3 Jul 2020 21:36:48 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Tomi Valkeinen <tomi.valkeinen@...com>
Cc:     Adam Ford <aford173@...il.com>, linux-fbdev@...r.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        stable@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH] omapfb: dss: Fix max fclk divider for omap36xx

Hi Tomi.

On Fri, Jul 03, 2020 at 10:17:29AM +0300, Tomi Valkeinen wrote:
> On 30/06/2020 21:26, Adam Ford wrote:
> > The drm/omap driver was fixed to correct an issue where using a
> > divider of 32 breaks the DSS despite the TRM stating 32 is a valid
> > number.  Through experimentation, it appears that 31 works, and
> > it is consistent with the value used by the drm/omap driver.
> > 
> > This patch fixes the divider for fbdev driver instead of the drm.
> > 
> > Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
> > 
> > Cc: <stable@...r.kernel.org> #4.9+
> > Signed-off-by: Adam Ford <aford173@...il.com>
> > ---
> > Linux 4.4 will need a similar patch, but it doesn't apply cleanly.
> > 
> > The DRM version of this same fix is:
> > e2c4ed148cf3 ("drm/omap: fix max fclk divider for omap36xx")
> > 
> > 
> > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.c b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> > index 7252d22dd117..bfc5c4c5a26a 100644
> > --- a/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> > +++ b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> > @@ -833,7 +833,7 @@ static const struct dss_features omap34xx_dss_feats = {
> >   };
> >   static const struct dss_features omap3630_dss_feats = {
> > -	.fck_div_max		=	32,
> > +	.fck_div_max		=	31,
> >   	.dss_fck_multiplier	=	1,
> >   	.parent_clk_name	=	"dpll4_ck",
> >   	.dpi_select_source	=	&dss_dpi_select_source_omap2_omap3,
> > 
> 
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@...com>
Will you apply to drm-misc?

Note  following output from "dim fixes":
$ dim fixes f76ee892a99e
Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
Cc: Tomi Valkeinen <tomi.valkeinen@...com>
Cc: Dave Airlie <airlied@...il.com>
Cc: Rob Clark <robdclark@...il.com>
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Sam Ravnborg <sam@...nborg.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc: Jason Yan <yanaijie@...wei.com>
Cc: "Andrew F. Davis" <afd@...com>
Cc: YueHaibing <yuehaibing@...wei.com>
Cc: <stable@...r.kernel.org> # v4.5+

Here it says the fix is valid from v4.5 onwards.

	Sam
> 
>  Tomi
> 
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives