lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 4 Jul 2020 14:23:09 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Cc: Miquel Raynal <miquel.raynal@...tlin.com>, Thierry Reding <thierry.reding@...il.com>, Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <bgolaszewski@...libre.com>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, linux-pwm@...r.kernel.org, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v6] gpio: pca953x: Add Maxim MAX7313 PWM support On Fri, Jul 3, 2020 at 5:53 PM Uwe Kleine-König <u.kleine-koenig@...gutronix.de> wrote: > On Sun, May 03, 2020 at 12:54:53PM +0200, Miquel Raynal wrote: ... > > + ret = regmap_read(pca_chip->regmap, reg, &val); > > + mutex_unlock(&pca_chip->i2c_lock); > > + if (ret < 0) { > > + dev_err(dev, "Cannot retrieve PWM intensity (%d)\n", ret); > > Please use %pe for error codes. %pe is mainly for error pointers, with plain integers it will look awkward a bit. > > + return 0; > > + } -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists