linux-kernel - Re: [PATCH] nfsd: Use seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E1D55112-90D0-4B1E-AB57-74F2C782F973@oracle.com>
Date:   Sat, 4 Jul 2020 10:31:46 -0400
From:   Chuck Lever <chuck.lever@...cle.com>
To:     Xu Wang <vulab@...as.ac.cn>
Cc:     Bruce Fields <bfields@...ldses.org>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfsd: Use seq_putc() in two functions

Hi-

> On Jun 17, 2020, at 9:56 PM, Xu Wang <vulab@...as.ac.cn> wrote:
> 
> A single character (line break) should be put into a sequence.
> Thus use the corresponding function "seq_putc()".
> 
> Signed-off-by: Xu Wang <vulab@...as.ac.cn>

Applied to nfsd-5.9. Thanks.


> ---
> fs/nfsd/nfs4idmap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4idmap.c b/fs/nfsd/nfs4idmap.c
> index 9460be8a8321..f92161ce1f97 100644
> --- a/fs/nfsd/nfs4idmap.c
> +++ b/fs/nfsd/nfs4idmap.c
> @@ -168,7 +168,7 @@ idtoname_show(struct seq_file *m, struct cache_detail *cd, struct cache_head *h)
> 			ent->id);
> 	if (test_bit(CACHE_VALID, &h->flags))
> 		seq_printf(m, " %s", ent->name);
> -	seq_printf(m, "\n");
> +	seq_putc(m, '\n');
> 	return 0;
> }
> 
> @@ -346,7 +346,7 @@ nametoid_show(struct seq_file *m, struct cache_detail *cd, struct cache_head *h)
> 			ent->name);
> 	if (test_bit(CACHE_VALID, &h->flags))
> 		seq_printf(m, " %u", ent->id);
> -	seq_printf(m, "\n");
> +	seq_putc(m, '\n');
> 	return 0;
> }
> 
> -- 
> 2.17.1
> 

--
Chuck Lever