linux-kernel - Re: [PATCH] habanalbas: rephrase error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf12WXAnVA1mTCxiifG7npi4hVJquPvC_NTG-9c4Gyc+u1A@mail.gmail.com>
Date:   Sun, 5 Jul 2020 00:39:04 +0300
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Omer Shpigelman <oshpigelman@...ana.ai>
Cc:     "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] habanalbas: rephrase error message

On Sat, Jul 4, 2020 at 10:51 PM Omer Shpigelman <oshpigelman@...ana.ai> wrote:
>
> Rephrase F/W error message to make it more understandable to ordinary
> users.
>
> Signed-off-by: Omer Shpigelman <oshpigelman@...ana.ai>
> ---
>  drivers/misc/habanalabs/firmware_if.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/firmware_if.c b/drivers/misc/habanalabs/firmware_if.c
> index baf790cf4b78..171baa2b56b0 100644
> --- a/drivers/misc/habanalabs/firmware_if.c
> +++ b/drivers/misc/habanalabs/firmware_if.c
> @@ -566,7 +566,8 @@ int hl_fw_init_cpu(struct hl_device *hdev, u32 cpu_boot_status_reg,
>                                 "Device reports FIT image is corrupted\n");
>                 else
>                         dev_err(hdev->dev,
> -                               "Device failed to load, %d\n", status);
> +                               "Failed to load firmware to device, %d\n",
> +                               status);
>
>                 rc = -EIO;
>                 goto out;
> --
> 2.17.1
>

This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@...il.com>