linux-kernel - [PATCH] ASoC: amd: fix Kconfig warning for Renoir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7849ce3b-e0f0-d28d-cf9d-d0560a5b4bc8@infradead.org>
Date:   Fri, 3 Jul 2020 21:11:56 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     LKML <linux-kernel@...r.kernel.org>,
        moderated for non-subscribers <alsa-devel@...a-project.org>,
        Takashi Iwai <tiwai@...e.de>, Mark Brown <broonie@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Vijendar Mukunda <Vijendar.Mukunda@....com>
Subject: [PATCH] ASoC: amd: fix Kconfig warning for Renoir

From: Randy Dunlap <rdunlap@...radead.org>

SND_SOC_DMIC depends on GPIOLIB so this driver should also depend on
GPIOLIB to make kconfig happy.

WARNING: unmet direct dependencies detected for SND_SOC_DMIC
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
  Selected by [y]:
  - SND_SOC_AMD_RENOIR_MACH [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AMD_RENOIR [=y]

Fixes: 1d3776669323 ("ASoC: amd: enable build for RN machine driver")
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Vijendar Mukunda <Vijendar.Mukunda@....com>
Cc: Mark Brown <broonie@...nel.org>
---
Found in mmotm.

There are no object file build errors. I suppose that gpiolib stubs
take care of that. Maybe some other patch would be more appropriate.

 sound/soc/amd/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- mmotm-2020-0703-1503.orig/sound/soc/amd/Kconfig
+++ mmotm-2020-0703-1503/sound/soc/amd/Kconfig
@@ -47,5 +47,6 @@ config SND_SOC_AMD_RENOIR_MACH
 	tristate "AMD Renoir support for DMIC"
 	select SND_SOC_DMIC
 	depends on SND_SOC_AMD_RENOIR
+	depends on GPIOLIB
 	help
 	 This option enables machine driver for DMIC