linux-kernel - Re: [PATCH] i2c: jz4780: remove redundant assignment to variable i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200704063217.GG1041@kunai>
Date:   Sat, 4 Jul 2020 08:32:17 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Paul Cercueil <paul@...pouillou.net>, linux-i2c@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: jz4780: remove redundant assignment to variable i

On Wed, Jun 10, 2020 at 01:59:01PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable i is being initialized with a value that is
> never read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

What about 'ret'? Doesn't the same reasoning apply for it?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)