linux-kernel - Re: [PATCH] tty: serial: meson

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66dcb907f3b9c5413cebe14e0bec00a4@kernel.org>
Date:   Sun, 05 Jul 2020 11:28:56 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kevin Hilman <khilman@...libre.com>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        linux-amlogic@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel-team@...roid.com,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH] tty: serial: meson_uart: Init port lock early

On 2020-07-05 11:07, Andy Shevchenko wrote:
> On Sun, Jul 5, 2020 at 12:32 PM Marc Zyngier <maz@...nel.org> wrote:
>> 
>> The meson UART driver triggers a lockdep splat at boot time, due
>> to the new expectation that the driver has to initialize the
>> per-port spinlock itself.
>> 
>> It remains unclear why a double initialization of the port
>> spinlock is a desirable outcome, but in the meantime let's
>> fix the splat.
>> 
> 
> Thanks!
> 
> Can you test patch from [1] if it helps and doesn't break anything in 
> your case?
> 
> [1]:
> https://lore.kernel.org/linux-serial/20200217114016.49856-1-andriy.shevchenko@linux.intel.com/T/#m9255e2a7474b160e66c7060fca5323ca3df49cfd

On its own, this patch doesn't seem to cure the issue (and it
adds a compile-time warning due to unused flags).

Or did you mean to test it in complement of my patch?

         M.
-- 
Jazz is not dead. It just smells funny...