linux-kernel - arch/powerpc/platforms/powernv/pci-ioda.c:1889:13: warning: function 'pnv_ioda_setup_bus_dma' is not needed and will not be emitted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 5 Jul 2020 19:02:17 +0800
From:   kernel test robot <lkp@...el.com>
To:     Oliver O'Halloran <oohall@...il.com>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-kernel@...r.kernel.org, Michael Ellerman <mpe@...erman.id.au>
Subject: arch/powerpc/platforms/powernv/pci-ioda.c:1889:13: warning: function
 'pnv_ioda_setup_bus_dma' is not needed and will not be emitted

Hi Oliver,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   35e884f89df4c48566d745dc5a97a0d058d04263
commit: dc3d8f85bb571c3640ebba24b82a527cf2cb3f24 powerpc/powernv/pci: Re-work bus PE configuration
date:   5 weeks ago
config: powerpc64-randconfig-r035-20200705 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project f804bd586ee58199db4cfb2da8e9ef067425900b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc64 cross compiling tool for clang build
        # apt-get install binutils-powerpc64-linux-gnu
        git checkout dc3d8f85bb571c3640ebba24b82a527cf2cb3f24
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   arch/powerpc/platforms/powernv/pci-ioda.c:1494:6: warning: no previous prototype for function 'pnv_pci_sriov_disable' [-Wmissing-prototypes]
   void pnv_pci_sriov_disable(struct pci_dev *pdev)
        ^
   arch/powerpc/platforms/powernv/pci-ioda.c:1494:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void pnv_pci_sriov_disable(struct pci_dev *pdev)
   ^
   static 
   arch/powerpc/platforms/powernv/pci-ioda.c:1604:5: warning: no previous prototype for function 'pnv_pci_sriov_enable' [-Wmissing-prototypes]
   int pnv_pci_sriov_enable(struct pci_dev *pdev, u16 num_vfs)
       ^
   arch/powerpc/platforms/powernv/pci-ioda.c:1604:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int pnv_pci_sriov_enable(struct pci_dev *pdev, u16 num_vfs)
   ^
   static 
   arch/powerpc/platforms/powernv/pci-ioda.c:1719:5: warning: no previous prototype for function 'pnv_pcibios_sriov_disable' [-Wmissing-prototypes]
   int pnv_pcibios_sriov_disable(struct pci_dev *pdev)
       ^
   arch/powerpc/platforms/powernv/pci-ioda.c:1719:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int pnv_pcibios_sriov_disable(struct pci_dev *pdev)
   ^
   static 
   arch/powerpc/platforms/powernv/pci-ioda.c:1728:5: warning: no previous prototype for function 'pnv_pcibios_sriov_enable' [-Wmissing-prototypes]
   int pnv_pcibios_sriov_enable(struct pci_dev *pdev, u16 num_vfs)
       ^
   arch/powerpc/platforms/powernv/pci-ioda.c:1728:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int pnv_pcibios_sriov_enable(struct pci_dev *pdev, u16 num_vfs)
   ^
   static 
>> arch/powerpc/platforms/powernv/pci-ioda.c:1889:13: warning: function 'pnv_ioda_setup_bus_dma' is not needed and will not be emitted [-Wunneeded-internal-declaration]
   static void pnv_ioda_setup_bus_dma(struct pnv_ioda_pe *pe, struct pci_bus *bus)
               ^
   5 warnings generated.

vim +/pnv_ioda_setup_bus_dma +1889 arch/powerpc/platforms/powernv/pci-ioda.c

fe7e85c6f5ff63 Gavin Shan             2014-09-30  1888  
5eada8a3f087df Alexey Kardashevskiy   2018-12-19 @1889  static void pnv_ioda_setup_bus_dma(struct pnv_ioda_pe *pe, struct pci_bus *bus)
74251fe21bfa93 Benjamin Herrenschmidt 2013-07-01  1890  {
74251fe21bfa93 Benjamin Herrenschmidt 2013-07-01  1891  	struct pci_dev *dev;
74251fe21bfa93 Benjamin Herrenschmidt 2013-07-01  1892  
74251fe21bfa93 Benjamin Herrenschmidt 2013-07-01  1893  	list_for_each_entry(dev, &bus->devices, bus_list) {
b348aa65297659 Alexey Kardashevskiy   2015-06-05  1894  		set_iommu_table_base(&dev->dev, pe->table_group.tables[0]);
0617fc0ca412b5 Christoph Hellwig      2019-02-13  1895  		dev->dev.archdata.dma_offset = pe->tce_bypass_base;
dff4a39e880062 Gavin Shan             2014-07-15  1896  
5c89a87d13d168 Alexey Kardashevskiy   2015-06-18  1897  		if ((pe->flags & PNV_IODA_PE_BUS_ALL) && dev->subordinate)
5eada8a3f087df Alexey Kardashevskiy   2018-12-19  1898  			pnv_ioda_setup_bus_dma(pe, dev->subordinate);
74251fe21bfa93 Benjamin Herrenschmidt 2013-07-01  1899  	}
74251fe21bfa93 Benjamin Herrenschmidt 2013-07-01  1900  }
74251fe21bfa93 Benjamin Herrenschmidt 2013-07-01  1901  

:::::: The code at line 1889 was first introduced by commit
:::::: 5eada8a3f087df74af1c2797770a3e2249374fe1 powerpc/iommu_api: Move IOMMU groups setup to a single place

:::::: TO: Alexey Kardashevskiy <aik@...abs.ru>
:::::: CC: Michael Ellerman <mpe@...erman.id.au>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (24764 bytes)