linux-kernel - Re: [PATCH] iio: adc: ad7780: Fix a resource handling path in 'ad7780

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200705125935.025cfa12@archlinux>
Date:   Sun, 5 Jul 2020 12:59:35 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Renato Lui Geh <renatogeh@...il.com>
Cc:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Michael.Hennerich@...log.com, lars@...afoo.de, knaack.h@....de,
        pmeerw@...erw.net, giuliano.belinassi@....br,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad7780: Fix a resource handling path in
 'ad7780_probe()'

On Sun, 17 May 2020 23:21:29 -0300
Renato Lui Geh <renatogeh@...il.com> wrote:

> Acked-by: Renato Lui Geh <renatogeh@...il.com>
> 
> On 05/17, Christophe JAILLET wrote:
> >If 'ad7780_init_gpios()' fails, we must not release some resources that
> >have not been allocated yet. Return directly instead.
> >
> >Fixes: 5bb30e7daf00 ("staging: iio: ad7780: move regulator to after GPIO init")
> >Fixes: 9085daa4abcc ("staging: iio: ad7780: add gain & filter gpio support")
> >Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> >---
> > drivers/iio/adc/ad7780.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/iio/adc/ad7780.c b/drivers/iio/adc/ad7780.c
> >index f47606ebbbbe..b33fe6c3907e 100644
> >--- a/drivers/iio/adc/ad7780.c
> >+++ b/drivers/iio/adc/ad7780.c
> >@@ -329,7 +329,7 @@ static int ad7780_probe(struct spi_device *spi)
> >
> > 	ret = ad7780_init_gpios(&spi->dev, st);
> > 	if (ret)
> >-		goto error_cleanup_buffer_and_trigger;
> >+		return ret;
> >
> > 	st->reg = devm_regulator_get(&spi->dev, "avdd");
> > 	if (IS_ERR(st->reg))
> >-- 
> >2.25.1
> >