linux-kernel - Re: [FOR-STABLE-3.9+] sched/rt: Show the 'sched_rr_timeslice' SCHED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 5 Jul 2020 09:30:41 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Greg KH <gregkh@...uxfoundation.org>, stable@...r.kernel.org,
        linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [FOR-STABLE-3.9+] sched/rt: Show the 'sched_rr_timeslice'
 SCHED_RR timeslice tuning knob in milliseconds

On Fri, Jul 03, 2020 at 01:13:54PM +0530, Viresh Kumar wrote:
>On 03-07-20, 09:40, Greg KH wrote:
>> On Fri, Jul 03, 2020 at 12:54:04PM +0530, Viresh Kumar wrote:
>> > From: Shile Zhang <shile.zhang@...ia.com>
>> >
>> > We added the 'sched_rr_timeslice_ms' SCHED_RR tuning knob in this commit:
>> >
>> >   ce0dbbbb30ae ("sched/rt: Add a tuning knob to allow changing SCHED_RR timeslice")
>> >
>> > ... which name suggests to users that it's in milliseconds, while in reality
>> > it's being set in milliseconds but the result is shown in jiffies.
>> >
>> > This is obviously confusing when HZ is not 1000, it makes it appear like the
>> > value set failed, such as HZ=100:
>> >
>> >   root# echo 100 > /proc/sys/kernel/sched_rr_timeslice_ms
>> >   root# cat /proc/sys/kernel/sched_rr_timeslice_ms
>> >   10
>> >
>> > Fix this to be milliseconds all around.
>> >
>> > Cc: <stable@...r.kernel.org> # v3.9+
>> > Signed-off-by: Shile Zhang <shile.zhang@...ia.com>
>> > Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
>> > Cc: Linus Torvalds <torvalds@...ux-foundation.org>
>> > Cc: Mike Galbraith <efault@....de>
>> > Cc: Peter Zijlstra <peterz@...radead.org>
>> > Cc: Thomas Gleixner <tglx@...utronix.de>
>> > Link: http://lkml.kernel.org/r/1485612049-20923-1-git-send-email-shile.zhang@nokia.com
>> > Signed-off-by: Ingo Molnar <mingo@...nel.org>
>> > Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
>>
>> What is the git commit id of this patch in Linus's tree?
>
>I am really sorry for missing the only thing I was required to do :(
>
>commit 975e155ed8732cb81f55c021c441ae662dd040b5 upstream.

I've queued it for 4.9 and 4.4.

-- 
Thanks,
Sasha