[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6b1d0837-e898-c5b2-c212-4ce1f2d41cdb@suse.com>
Date: Sun, 5 Jul 2020 17:48:34 +0300
From: Nikolay Borisov <nborisov@...e.com>
To: trix@...hat.com, clm@...com, josef@...icpanda.com, dsterba@...e.com
Cc: linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btfrs: initialize return of btrfs_extent_same
On 5.07.20 г. 17:20 ч., trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
>
> clang static analysis flags a garbage return
>
> fs/btrfs/reflink.c:611:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn]
> return ret;
> ^~~~~~~~~~
> ret will not be set when olen is 0
> When olen is 0, this function does no work.
>
> So initialize ret to 0
>
> Signed-off-by: Tom Rix <trix@...hat.com>
And I forgot:
Reviewed-by: Nikolay Borisov <nborisov@...e.com>
> ---
> fs/btrfs/reflink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/reflink.c b/fs/btrfs/reflink.c
> index 040009d1cc31..200a80fcbecb 100644
> --- a/fs/btrfs/reflink.c
> +++ b/fs/btrfs/reflink.c
> @@ -572,7 +572,7 @@ static int btrfs_extent_same_range(struct inode *src, u64 loff, u64 len,
> static int btrfs_extent_same(struct inode *src, u64 loff, u64 olen,
> struct inode *dst, u64 dst_loff)
> {
> - int ret;
> + int ret = 0;
> u64 i, tail_len, chunk_count;
> struct btrfs_root *root_dst = BTRFS_I(dst)->root;
>
>
Powered by blists - more mailing lists