[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAK7LNAS8pTFfhHb_Z+Hh5LWZ2DCCzfGtTq4oizykOYb_QRqgMw@mail.gmail.com>
Date: Mon, 6 Jul 2020 00:34:52 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Paul Menzel <pmenzel@...gen.mpg.de>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig`
On Sun, Jul 5, 2020 at 4:19 PM Paul Menzel <pmenzel@...gen.mpg.de> wrote:
>
> Dear Masahiro,
>
>
> Am 05.07.20 um 09:14 schrieb Masahiro Yamada:
> > On Thu, Jul 2, 2020 at 8:12 PM Paul Menzel <pmenzel@...gen.mpg.de> wrote:
> >>
> >> Running `make savedefconfig` creates by default `defconfig`, which is,
> >> currently, on git’s radar, for example, `git status` lists this file as
> >> untracked.
> >>
> >> So, add the file to `.gitignore`, so it’s ignored by git.
> >>
> >> Cc: linux-kernel@...r.kernel.org
> >> Signed-off-by: Paul Menzel <pmenzel@...gen.mpg.de>
> >> ---
> >> .gitignore | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/.gitignore b/.gitignore
> >> index 87b9dd8a163b..f07500889fba 100644
> >> --- a/.gitignore
> >> +++ b/.gitignore
> >> @@ -143,6 +143,9 @@ x509.genkey
> >> /allrandom.config
> >> /allyes.config
> >>
> >> +# Kconfig presets, default savedefconfg output
> >
> >
> > I just noticed this comment is wrong
> > since 'defconfig' is not a preset.
> >
> > I will change it to 'Kconfig savedefconfig output'.
>
> Thank you for finding my error and correcting it.
>
> I couldn’t find out more about *presets*.
>
> $ git grep -i preset scripts/kconfig/
> $
>
> Where can I look, so I won’t repeat the same mistake next time?
You can find 'preset' in
Documentation/kbuild/kconfig.rst
but it does appear in the source files.
--
Best Regards
Masahiro Yamada
Powered by blists - more mailing lists