linux-kernel - Re: [PATCH V6] serial: msm_geni_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202007051402.dpamHM3x%lkp@intel.com>
Date:   Sun, 5 Jul 2020 14:10:56 +0800
From:   kernel test robot <lkp@...el.com>
To:     Akash Asthana <akashast@...eaurora.org>, gregkh@...uxfoundation.org
Cc:     kbuild-all@...ts.01.org, msavaliy@...eaurora.org,
        saravanak@...gle.com, sspatil@...gle.com, tkjos@...gle.com,
        linux-arm-msm@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Akash Asthana <akashast@...eaurora.org>
Subject: Re: [PATCH V6] serial: msm_geni_serial_console : Add Earlycon support

Hi Akash,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tty/tty-testing]
[also build test WARNING on usb/usb-testing v5.8-rc3 next-20200703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Akash-Asthana/serial-msm_geni_serial_console-Add-Earlycon-support/20200622-181041
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: m68k-randconfig-r003-20200705 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/tty/serial/msm_geni_serial_console.c: In function 'msm_geni_serial_earlycon_setup':
>> drivers/tty/serial/msm_geni_serial_console.c:400:6: warning: variable 'rx_stale' set but not used [-Wunused-but-set-variable]
     400 |  u32 rx_stale = 0;
         |      ^~~~~~~~
>> drivers/tty/serial/msm_geni_serial_console.c:398:6: warning: variable 'rx_parity_cfg' set but not used [-Wunused-but-set-variable]
     398 |  u32 rx_parity_cfg = 0;
         |      ^~~~~~~~~~~~~
>> drivers/tty/serial/msm_geni_serial_console.c:397:6: warning: variable 'rx_trans_cfg' set but not used [-Wunused-but-set-variable]
     397 |  u32 rx_trans_cfg = 0;
         |      ^~~~~~~~~~~~

vim +/rx_stale +400 drivers/tty/serial/msm_geni_serial_console.c

   388	
   389	static int __init
   390	msm_geni_serial_earlycon_setup(struct earlycon_device *dev,
   391			const char *opt)
   392	{
   393		struct uart_port *uport = &dev->port;
   394		int ret = 0;
   395		u32 tx_trans_cfg = 0;
   396		u32 tx_parity_cfg = 0;
 > 397		u32 rx_trans_cfg = 0;
 > 398		u32 rx_parity_cfg = 0;
   399		u32 stop_bit = 0;
 > 400		u32 rx_stale = 0;

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (20714 bytes)