[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200705065514.GA34145@kroah.com>
Date: Sun, 5 Jul 2020 08:55:14 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Al Viro <viro@...iv.linux.org.uk>,
"Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>,
Shuah Khan <shuah@...nel.org>,
Linux API <linux-api@...r.kernel.org>,
Linux FS Devel <linux-fsdevel@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-man@...r.kernel.org,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH 3/3] selftests: add readfile(2) selftests
On Sat, Jul 04, 2020 at 08:38:26PM +0200, Geert Uytterhoeven wrote:
> Hi Greg,
>
> On Sat, Jul 4, 2020 at 4:05 PM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> > Test the functionality of readfile(2) in various ways.
> >
> > Also provide a simple speed test program to benchmark using readfile()
> > instead of using open()/read()/close().
> >
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>
> Any benchmark results to share?
Yes, the readfile_speed.c file will show you that on your machine, I'll
post the results of that for two of my machines when I send the next
version of this patch series.
>
> > --- /dev/null
> > +++ b/tools/testing/selftests/readfile/readfile.c
>
> > +static void readfile(const char *filename)
> > +{
> > +// int root_fd;
>
> ???
Ugh, sorry about that, I obviously didn't clean up my last tests from
this file, thanks for catching that.
I should add more tests to validate the flag handling as well, will do
all of that for the next version, thanks for noticing this.
greg k-h
Powered by blists - more mailing lists