linux-kernel - Re: [PATCH -next] locktorture: make function torture_percpu_rwsem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200706225257.GP9247@paulmck-ThinkPad-P72>
Date:   Mon, 6 Jul 2020 15:52:57 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Hulk Robot <hulkci@...wei.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        Josh Triplett <josh@...htriplett.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] locktorture: make function
 torture_percpu_rwsem_init() static

On Fri, Jul 03, 2020 at 01:05:27PM +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
> 
> kernel/locking/locktorture.c:569:6: warning:
>  symbol 'torture_percpu_rwsem_init' was not declared. Should it be static?
> 
> And this function is not used outside of locktorture.c,
> so this commit marks it static.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Applied, thank you!!!

							Thanx, Paul

> ---
>  kernel/locking/locktorture.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
> index 9cfa5e89cff7..62d215b2e39f 100644
> --- a/kernel/locking/locktorture.c
> +++ b/kernel/locking/locktorture.c
> @@ -566,7 +566,7 @@ static struct lock_torture_ops rwsem_lock_ops = {
>  #include <linux/percpu-rwsem.h>
>  static struct percpu_rw_semaphore pcpu_rwsem;
>  
> -void torture_percpu_rwsem_init(void)
> +static void torture_percpu_rwsem_init(void)
>  {
>  	BUG_ON(percpu_init_rwsem(&pcpu_rwsem));
>  }
>