linux-kernel - Re: [PATCH v4] selftests: tpm: upgrade TPM2 tests from Python 2 to Python 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200706230203.GB20770@linux.intel.com>
Date:   Tue, 7 Jul 2020 02:02:03 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Shuah Khan <skhan@...uxfoundation.org>
Cc:     Pengfei Xu <pengfei.xu@...el.com>, Shuah Khan <shuah@...nel.org>,
        Qiuxu Zhuo <qiuxu.zhuo@...el.com>, Heng Su <heng.su@...el.com>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kai Svahn <kai.svahn@...el.com>
Subject: Re: [PATCH v4] selftests: tpm: upgrade TPM2 tests from Python 2 to
 Python 3

On Mon, Jul 06, 2020 at 02:32:13PM -0600, Shuah Khan wrote:
> On 7/6/20 2:12 PM, Shuah Khan wrote:
> > On 7/2/20 7:20 PM, Pengfei Xu wrote:
> > > Thanks a lot Jarkko and Shuah!
> > > 
> > > BR.
> > > Thanks!
> > > 
> > > On 2020-07-02 at 15:32:49 -0600, Shuah Khan wrote:
> > > > On 7/2/20 1:44 PM, Jarkko Sakkinen wrote:
> > > > > On Fri, Jun 26, 2020 at 11:40:52AM +0800, Pengfei Xu wrote:
> > > > > > Python 2 is no longer supported by the Python upstream project, so
> > > > > > upgrade TPM2 tests to Python 3.
> > > > > > 
> > > > > > Signed-off-by: Pengfei Xu <pengfei.xu@...el.com>
> > > > > 
> > > > > I think that it's perfect now. Thank you.
> > > > > 
> > > > > Also
> > > > > 
> > > > > 1. I checked that scripts/checkpatch.pl did not report any errors.
> > > > > 2. sudo python3 -m unittest -v tpm2_tests.SmokeTest
> > > > > 3. sudo python3 -m unittest -v tpm2_tests.SpaceTest
> > > > > 
> > > > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> > > > > Tested-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> > > > > 
> > > > > Shuah, I could pick this up after your PR (with my earlier fixes) lands
> > > > > to mainline, and sort out possible merge conflicts if they uprise. Is
> > > > > this fine by you?
> > > > > 
> > > > 
> > 
> > I started applying this and then passed.
> > 
> > Doesn't this test fail if python3 isn't installed? Do you have to
> > support both versions?
> > 
> 
> Never mind. Tested it on with python2. All is well. Applied to
> linux-kselftest fixes for Linux 5.8-rc5
> 
> thanks,
> -- Shuah

OK, great, thanks a lot!

/Jarkko