linux-kernel - 回复: [PATCH] usb: gadget: function: fix missing spinlock in f_uac1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR11MB26320D89506AFF3949602C94FF690@BYAPR11MB2632.namprd11.prod.outlook.com>
Date:   Mon, 6 Jul 2020 05:16:30 +0000
From:   "Zhang, Qiang" <Qiang.Zhang@...driver.com>
To:     "balbi@...nel.org" <balbi@...nel.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "colin.king@...onical.com" <colin.king@...onical.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ruslan.bilovol@...il.com" <ruslan.bilovol@...il.com>,
        "cooloney@...nel.org" <cooloney@...nel.org>
Subject: 回复: [PATCH] usb: gadget: function: fix missing spinlock in f_uac1_legacy


________________________________________
发件人: linux-kernel-owner@...r.kernel.org <linux-kernel-owner@...r.kernel.org> 代表 qiang.zhang@...driver.com <qiang.zhang@...driver.com>
发送时间: 2020年7月5日 9:59
收件人: balbi@...nel.org
抄送: gregkh@...uxfoundation.org; colin.king@...onical.com; linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org
主题: [PATCH] usb: gadget: function: fix missing spinlock in f_uac1_legacy

From: Zhang Qiang <qiang.zhang@...driver.com>

Signed-off-by: Zhang Qiang <qiang.zhang@...driver.com>
---
 drivers/usb/gadget/function/f_uac1_legacy.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/gadget/function/f_uac1_legacy.c b/drivers/usb/gadget/function/f_uac1_legacy.c
index 349deae7cabd..e2d7f69128a0 100644
--- a/drivers/usb/gadget/function/f_uac1_legacy.c
+++ b/drivers/usb/gadget/function/f_uac1_legacy.c
@@ -336,7 +336,9 @@ static int f_audio_out_ep_complete(struct usb_ep *ep, struct usb_request *req)

        /* Copy buffer is full, add it to the play_queue */
        if (audio_buf_size - copy_buf->actual < req->actual) {
+               spin_lock_irq(&audio->lock);
                list_add_tail(&copy_buf->list, &audio->play_queue);
+               spin_unlock_irq(&audio->lock);
                schedule_work(&audio->playback_work);
                copy_buf = f_audio_buffer_alloc(audio_buf_size);
                if (IS_ERR(copy_buf))
--
2.24.1