linux-kernel - RE: [PATCH v2] rtc: rtc-ds1374: wdt: Use watchdog core for watchdog part

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <HK2PR01MB32810CD5ED24462A76A4B8E2FA690@HK2PR01MB3281.apcprd01.prod.exchangelabs.com>
Date:   Mon, 6 Jul 2020 06:58:16 +0000
From:   Johnson CH Chen (陳昭勳) 
        <JohnsonCH.Chen@...a.com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
CC:     Guenter Roeck <linux@...ck-us.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Alessandro Zummo <a.zummo@...ertech.it>
Subject: RE: [PATCH v2] rtc: rtc-ds1374: wdt: Use watchdog core for watchdog
 part

Hi,

> > > > +	ret = devm_watchdog_register_device(&client->dev, &ds1374->wdt);
> > > >  	if (ret) {
> > > > -		misc_deregister(&ds1374_miscdev);
> > > > +		dev_err(&client->dev, "failed to register DS1374 watchdog
> > > > +device\n");
> 
> There was no error message before, I don't think this one is necessary.
> 
> > > >  		return ret;
> > > >  	}
> > > > -	ds1374_wdt_settimeout(131072);
> > > > +
> > > > +	dev_info(&client->dev, "DS1374 watchdog device enabled\n");
> > >
> > > Is that necessary ?
> > >
> >
> > I think it's good to show watchdog initial timeout. I'll include above
> suggestions in v3, thanks!
> >
> 
> No, please avoid adding more strings in that driver.
> 

I get it, thanks for review!

Best regards,
Johnson
> 
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com