linux-kernel - Re: [PATCH v5 00/14] irqchip: Fix potential resource leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab1cd9280c7892a0230945ef5ff0880c@kernel.org>
Date:   Mon, 06 Jul 2020 08:30:57 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        linux-kernel@...r.kernel.org,
        Markus Elfring <Markus.Elfring@....de>
Subject: Re: [PATCH v5 00/14] irqchip: Fix potential resource leaks

On 2020-07-06 02:19, Tiezhu Yang wrote:
> When I test the irqchip code of Loongson, I read the related code of 
> other
> chips in drivers/irqchip and I find some potential resource leaks in 
> the
> error path, I think it is better to fix them.
> 
> v2:
>   - Split the first patch into a new patch series which
>     includes small patches and add "Fixes" tag
>   - Use "goto" label to handle error path in some patches
> 
> v3:
>   - Add missed variable "ret" in the patch #5 and #13
> 
> v4:
>   - Modify the commit message of each patch suggested by Markus Elfring
>   - Make "irq_domain_remove(root_domain)" under CONFIG_SMP in patch #3
>   - Add a return statement before goto label in patch #4
> 
> v5:
>   - Modify the commit messages and do some code cleanups

Please stop replying to Markus Elfring, and give people who actually
care a chance to review this code. Elfring will keep asking you to make
absolutely pointless changes until you are blue in the face

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...