lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 6 Jul 2020 17:44:16 +0900
From:   Joonsoo Kim <>
To:     Vlastimil Babka <>
Cc:     Andrew Morton <>,
        Linux Memory Management List <>,
        LKML <>,,
        Christoph Hellwig <>,
        Roman Gushchin <>,
        Mike Kravetz <>,
        Naoya Horiguchi <>,
        Michal Hocko <>,
        Joonsoo Kim <>
Subject: Re: [PATCH v3 8/8] mm/page_alloc: remove a wrapper for alloc_migration_target()

2020년 7월 4일 (토) 오전 1:18, Vlastimil Babka <>님이 작성:
> On 6/23/20 8:13 AM, wrote:
> > From: Joonsoo Kim <>
> >
> > There is a well-defined standard migration target callback.
> > Use it directly.
> >
> > Signed-off-by: Joonsoo Kim <>
> Acked-by: Vlastimil Babka <>
> But you could move this to patch 5/8 to reduce churn. And do the same with

Yes, I now realize that it is possible to make this change earlier.
However, reordering
the patches would cause additional change so I will not change the
order in the next
version. Result would be the same. :)

> mm/memory-failure.c new_page() there really, to drop the simple wrappers. Only

Okay. As you suggested below, with NUMA_NO_NODE handling, we can remove
the more wrappers. I will do it.

> new_node_page() is complex enough.
> Hm wait, new_node_page() is only called by do_migrate_range() which is only
> called by __offline_pages() with explicit test that all pages are from a single
> zone, so the nmask could also be setup just once and not per each page, making
> it possible to remove the wrapper.

I have tried this suggestion and found that code is not simpler than before.
However, there would be minor performance benefit so I will include
this change, too.

> But for new_page() you would have to define that mtc->nid == NUMA_NO_NODE means
> alloc_migrate_target() does page_to_nid(page) by itself.

Yes, I will use this suggestion.


Powered by blists - more mailing lists