linux-kernel - Re: [RESEND Patch v2 1/4] mm/mremap: format the check in move_normal_pmd() same as move_huge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200706100625.nxh5hd4m6rremzyt@box>
Date:   Mon, 6 Jul 2020 13:06:25 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Wei Yang <richard.weiyang@...ux.alibaba.com>
Cc:     akpm@...ux-foundation.org, kirill.shutemov@...ux.intel.com,
        yang.shi@...ux.alibaba.com, vbabka@...e.cz, willy@...radead.org,
        thomas_os@...pmail.org, thellstrom@...are.com,
        anshuman.khandual@....com, sean.j.christopherson@...el.com,
        aneesh.kumar@...ux.ibm.com, peterx@...hat.com, walken@...gle.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org, digetx@...il.com
Subject: Re: [RESEND Patch v2 1/4] mm/mremap: format the check in
 move_normal_pmd() same as move_huge_pmd()

On Fri, Jun 26, 2020 at 09:52:13PM +0800, Wei Yang wrote:
> No functional change, just improve the readability and prepare for
> following cleanup.

It's pretty much redundant. It doesn't provide any meaningful
readability improvement. Please drop the patch.

-- 
 Kirill A. Shutemov