linux-kernel - Re: [RESEND Patch v2 0/4] mm/mremap: cleanup move_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200706100819.flwgozlstn3zl66u@box>
Date:   Mon, 6 Jul 2020 13:08:19 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Wei Yang <richard.weiyang@...ux.alibaba.com>
Cc:     akpm@...ux-foundation.org, kirill.shutemov@...ux.intel.com,
        yang.shi@...ux.alibaba.com, vbabka@...e.cz, willy@...radead.org,
        thomas_os@...pmail.org, thellstrom@...are.com,
        anshuman.khandual@....com, sean.j.christopherson@...el.com,
        aneesh.kumar@...ux.ibm.com, peterx@...hat.com, walken@...gle.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org, digetx@...il.com
Subject: Re: [RESEND Patch v2 0/4] mm/mremap: cleanup move_page_tables() a
 little

On Fri, Jun 26, 2020 at 09:52:12PM +0800, Wei Yang wrote:
> move_page_tables() tries to move page table by PMD or PTE.
> 
> The root reason is if it tries to move PMD, both old and new range should be
> PMD aligned. But current code calculate old range and new range separately.
> This leads to some redundant check and calculation.
> 
> This cleanup tries to consolidate the range check in one place to reduce some
> extra range handling.

The patchet looks good to me. I have few nits, but nothing substantial.

Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

-- 
 Kirill A. Shutemov