linux-kernel - Re: [PATCH] lib/test_bitops: Do the full test during module init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXQX3MXCPjqoKkFh3Jh1dBqBKSBVSjT-DNhTn9YLCd2uA@mail.gmail.com>
Date:   Mon, 6 Jul 2020 13:28:53 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Wei Yang <richard.weiyang@...il.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lib/test_bitops: Do the full test during module init

Hi Andy,

On Mon, Jul 6, 2020 at 12:39 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Mon, Jul 6, 2020 at 12:53 PM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> > Currently, the bitops test consists of two parts: one part is executed
> > during module load, the second part during module unload. This is
> > cumbersome for the user, as he has to perform two steps to execute all
> > tests, and is different from most (all?) other tests.
> >
> > Merge the two parts, so both are executed during module load.
>
> Does your change prevent you from unloading the module?

Good point, you need a dummy module_exit() for that.
Stay tuned for v2.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds