lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 6 Jul 2020 15:00:05 +0300
From:   Andy Shevchenko <>
To:     Bartosz Golaszewski <>
Cc:     Sungbo Eo <>,
        Linus Walleij <>,
        Michael Walle <>,
        LKML <>,
        linux-gpio <>
Subject: Re: [PATCH v5 1/2] gpio: add GPO driver for PCA9570

On Mon, Jul 6, 2020 at 2:21 PM Bartosz Golaszewski
<> wrote:>
> On Sun, Jul 5, 2020 at 3:31 PM Sungbo Eo <> wrote:
> >
> > NXP PCA9570 is a 4-bit I2C GPO expander without interrupt functionality.
> > Its ports are controlled only by a data byte without register address.
> >

> > Datasheet:
> >

No blank line here.

> > Signed-off-by: Sungbo Eo <>

> This driver looks nice now but why did you remove the mutex in v3? I
> think when Andy commented on that, he meant not understanding why the
> error check is protected, not the i2c operations.


> Are you sure you don't need this lock?

It's a good point!

With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists