linux-kernel - Re: [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6202799b-f887-a867-94b3-915607956ceb@maciej.szmigiero.name>
Date:   Mon, 6 Jul 2020 14:41:26 +0200
From:   "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
To:     Filipe Laíns <filipe.lains@...il.com>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Harry Cutts <hcutts@...omium.org>,
        Peter Hutterer <peter.hutterer@...-t.net>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log
 messages

On 06.07.2020 14:38, Filipe Laíns wrote:
> On Sun, 2020-07-05 at 19:34 +0200, Maciej S. Szmigiero wrote:
>> These messages appear each time the mouse wakes from sleep, in my
>> case
>> (Logitech M705), every minute or so.
>> Let's downgrade them to the "debug" level so they don't fill the
>> kernel log
>> by default.
>>
>> While we are at it, let's make clear that this is a wheel multiplier
>> (and
>> not, for example, XY movement multiplier).
>>
>> Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling
>> on Logitech mice")
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name>
>> ---
>> Sending again since the previous message bounced for most recipients.
>>
>>  drivers/hid/hid-logitech-hidpp.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-
>> logitech-hidpp.c
>> index 1e1cf8eae649..b8b53dc95e86 100644
>> --- a/drivers/hid/hid-logitech-hidpp.c
>> +++ b/drivers/hid/hid-logitech-hidpp.c
>> @@ -3146,7 +3146,7 @@ static int hi_res_scroll_enable(struct
>> hidpp_device *hidpp)
>>  		multiplier = 1;
>>  
>>  	hidpp->vertical_wheel_counter.wheel_multiplier = multiplier;
>> -	hid_info(hidpp->hid_dev, "multiplier = %d\n", multiplier);
>> +	hid_dbg(hidpp->hid_dev, "wheel multiplier = %d\n", multiplier);
>>  	return 0;
>>  }
>>  
> 
> I have seen this being useful in some cases, however I do not have a
> strong opinion on it. Peter would know better.

Well, the message is not being removed, only hidden by default, so
it doesn't fill the kernel log.

One can still enable it at runtime if wanted.

> Cheers,
> Filipe Laíns
> 

Thanks,
Maciej