linux-kernel - Re: [PATCH 26/32] usb: early: xhci-dbc: Supply missing 'xhci-dbgp.h' headerfile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Jul 2020 15:50:11 +0200
From:   Jann Horn <jannh@...gle.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        kernel list <linux-kernel@...r.kernel.org>,
        linux-usb@...r.kernel.org, Lu Baolu <baolu.lu@...ux.intel.com>
Subject: Re: [PATCH 26/32] usb: early: xhci-dbc: Supply missing 'xhci-dbgp.h' headerfile

On Mon, Jul 6, 2020 at 3:34 PM Lee Jones <lee.jones@...aro.org> wrote:
> If the header file containing a function's prototype isn't included by
> the sourcefile containing the associated function, the build system
> complains of missing prototypes.
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’:
>  drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>  915 | int chunk, ret;
>  | ^~~
>  drivers/usb/early/xhci-dbc.c:600:12: warning: no previous prototype for ‘early_xdbc_parse_parameter’ [-Wmissing-prototypes]
>  600 | int __init early_xdbc_parse_parameter(char *s)
>  | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>  drivers/usb/early/xhci-dbc.c:653:12: warning: no previous prototype for ‘early_xdbc_setup_hardware’ [-Wmissing-prototypes]
>  653 | int __init early_xdbc_setup_hardware(void)
>  | ^~~~~~~~~~~~~~~~~~~~~~~~~
>  drivers/usb/early/xhci-dbc.c:910:13: warning: no previous prototype for ‘early_xdbc_register_console’ [-Wmissing-prototypes]
>  910 | void __init early_xdbc_register_console(void)
>  | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Cc: Jann Horn <jannh@...gle.com>
> Cc: Lu Baolu <baolu.lu@...ux.intel.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Reviewed-by: Jann Horn <jannh@...gle.com>