linux-kernel - Re: [PATCH] usb: core: fix quirks_param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74dc-5f032e00-69-5f1a6480@172803432>
Date:   Mon, 06 Jul 2020 15:58:17 +0200
From:   "Kars Mulder" <kerneldev@...smulder.nl>
To:     "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        "David Laight" <David.Laight@...lab.com>,
        "Kai-Heng Feng" <kai.heng.feng@...onical.com>,
        "Pavel Machek" <pavel@...x.de>,
        "Andy Shevchenko" <andy.shevchenko@...il.com>,
        "Oliver Neukum" <oneukum@...e.com>
Subject: Re: [PATCH] usb: core: fix quirks_param_set() writing to 
 a const pointer

On Monday, July 06, 2020 15:07 CEST, Greg Kroah-Hartman wrote: 
> Just test for memory allocation failure and handle it properly, it isn't
> hard to do.
> 
> 128 bytes on the stack can be a problem, don't get in the habit of doing
> so please.

Thank you for the clarification. The next version of my patch shall use
kstrdup() instead of copying to the stack.