lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 5 Jul 2020 18:30:30 -0700 From: Ian Rogers <irogers@...gle.com> To: Kajol Jain <kjain@...ux.ibm.com> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>, Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Paul Clarke <pc@...ibm.com>, Jiri Olsa <jolsa@...hat.com>, Namhyung Kim <namhyung@...nel.org>, Andi Kleen <ak@...ux.intel.com>, Jin Yao <yao.jin@...ux.intel.com>, LKML <linux-kernel@...r.kernel.org>, linux-perf-users <linux-perf-users@...r.kernel.org>, maddy@...ux.ibm.com, Ravi Bangoria <ravi.bangoria@...ux.ibm.com>, Anju T Sudhakar <anju@...ux.vnet.ibm.com>, "Liang, Kan" <kan.liang@...ux.intel.com>, nasastry@...ibm.com Subject: Re: [PATCH] perf/tools/pmu-events/powerpc: Added nest imc metric events On Thu, Jul 2, 2020 at 11:57 PM Kajol Jain <kjain@...ux.ibm.com> wrote: > > Added nest imc metric events. Acked-by: Ian Rogers <irogers@...gle.com> > Signed-off-by: Kajol Jain <kjain@...ux.ibm.com> > --- > .../arch/powerpc/power9/nest_metrics.json | 35 +++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/tools/perf/pmu-events/arch/powerpc/power9/nest_metrics.json b/tools/perf/pmu-events/arch/powerpc/power9/nest_metrics.json > index c121e526442a..8383a37647ad 100644 > --- a/tools/perf/pmu-events/arch/powerpc/power9/nest_metrics.json > +++ b/tools/perf/pmu-events/arch/powerpc/power9/nest_metrics.json > @@ -15,5 +15,40 @@ > "MetricExpr": "(hv_24x7@...PB_CYC\\,chip\\=?@ )", > "MetricName": "PowerBUS_Frequency", > "ScaleUnit": "2.5e-7GHz" > + }, > + { > + "MetricExpr" : "nest_mcs01_imc@...MCS01_128B_RD_DISP_PORT01@ + nest_mcs01_imc@...MCS01_128B_RD_DISP_PORT23@", > + "MetricName" : "mcs01-read", > + "MetricGroup" : "memory_bw", > + "ScaleUnit": "6.1e-5MB" nit: I'm guessing this is from: 64.0/(1024.0*1024.0) = 6.103515625e-05 and for reference: 64.0/(1000.0*1000.0) = 6.3999999999999997e-05 should the unit be MiB? https://en.wikipedia.org/wiki/Kibibyte Searching around I only see knightslanding using MiB but it seems to be using it in the 1000^2 case which probably means it should be MB: knightslanding/uncore-memory.json: "ScaleUnit": "6.4e-05MiB" Given there is some confusion I wonder if it makes sense to just make this 0.015625B and then we have a utility function that selects the best unit for "bytes" with config options similar to --big-num? Thanks, Ian > + }, > + { > + "MetricExpr" : "nest_mcs23_imc@...MCS23_128B_RD_DISP_PORT01@ + nest_mcs23_imc@...MCS23_128B_RD_DISP_PORT23@", > + "MetricName" : "mcs23-read", > + "MetricGroup" : "memory_bw", > + "ScaleUnit": "6.1e-5MB" > + }, > + { > + "MetricExpr" : "nest_mcs01_imc@...MCS01_128B_WR_DISP_PORT01@ + nest_mcs01_imc@...MCS01_128B_WR_DISP_PORT23@", > + "MetricName" : "mcs01-write", > + "MetricGroup" : "memory_bw", > + "ScaleUnit": "6.1e-5MB" > + }, > + { > + "MetricExpr" : "nest_mcs23_imc@...MCS23_128B_WR_DISP_PORT01@ + nest_mcs23_imc@...MCS23_128B_WR_DISP_PORT23@", > + "MetricName" : "mcs23-write", > + "MetricGroup" : "memory-bandwidth", > + "ScaleUnit": "6.1e-5MB" > + }, > + { > + "MetricExpr" : "nest_powerbus0_imc@...PB_CYC@", > + "MetricName" : "powerbus_freq", > + "ScaleUnit": "1e-9GHz" > + }, > + { > + "MetricExpr" : "(nest_mcs01_imc@...MCS01_128B_RD_DISP_PORT01@ + nest_mcs01_imc@...MCS01_128B_RD_DISP_PORT23@ + nest_mcs23_imc@...MCS23_128B_RD_DISP_PORT01@ + nest_mcs23_imc@...MCS23_128B_RD_DISP_PORT23@ + nest_mcs01_imc@...MCS01_128B_WR_DISP_PORT01@ + nest_mcs01_imc@...MCS01_128B_WR_DISP_PORT23@ + nest_mcs23_imc@...MCS23_128B_WR_DISP_PORT01@ + nest_mcs23_imc@...MCS23_128B_WR_DISP_PORT23@)", > + "MetricName" : "Memory-bandwidth-MCS", > + "MetricGroup" : "memory_bw", > + "ScaleUnit": "6.1e-5MB" > } > ] > -- > 2.17.1 >
Powered by blists - more mailing lists