linux-kernel - Re: [PATCH 1/1] watchdog: Add common nowayout parameter to booke

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <6b24e27b-c47a-8fd3-179b-761fb53f02b0@roeck-us.net>
Date:   Mon, 6 Jul 2020 08:10:06 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Timothy Myers <timothy.myers@...ran.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        David Boike <david.boike@...ran.com>
Subject: Re: [PATCH 1/1] watchdog: Add common nowayout parameter to booke_wdt
 driver

On 7/6/20 7:13 AM, Timothy Myers wrote:
> Add the common "nowayout" parameter to booke_wdt to make this behavior
> selectable at runtime and to make the implementation more consistent with
> many other watchdog drivers.
> 
> Signed-off-by: Timothy Myers <timothy.myers@...ran.com>
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>

The added Reviewed-by: makes it v2.

Anyway, your patch is whitespace corrupted.

ERROR: code indent should use tabs where possible
#36: FILE: drivers/watchdog/booke_wdt.c:45:
+               "Watchdog cannot be stopped once started (default="$

WARNING: please, no spaces at the start of a line
#36: FILE: drivers/watchdog/booke_wdt.c:45:
+               "Watchdog cannot be stopped once started (default="$

ERROR: code indent should use tabs where possible
#37: FILE: drivers/watchdog/booke_wdt.c:46:
+                               __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");$

WARNING: please, no spaces at the start of a line
#37: FILE: drivers/watchdog/booke_wdt.c:46:
+                               __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");$

That explains a lot. I guess it is corrupted so badly that patchwork
doesn't recognize it as patch. Sorry, won't be able to apply it.
Please send a non-corrupted version.

Guenter

> ---
>  drivers/watchdog/booke_wdt.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c
> index 9d09bbfdef20..7817fb976f9c 100644
> --- a/drivers/watchdog/booke_wdt.c
> +++ b/drivers/watchdog/booke_wdt.c
> @@ -39,6 +39,11 @@ static bool booke_wdt_enabled;
>  module_param(booke_wdt_enabled, bool, 0);
>  static int  booke_wdt_period = CONFIG_BOOKE_WDT_DEFAULT_TIMEOUT;
>  module_param(booke_wdt_period, int, 0);
> +static bool nowayout = WATCHDOG_NOWAYOUT;
> +module_param(nowayout, bool, 0);
> +MODULE_PARM_DESC(nowayout,
> +               "Watchdog cannot be stopped once started (default="
> +                               __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
> 
>  #ifdef CONFIG_PPC_FSL_BOOK3E
> 
> @@ -215,7 +220,6 @@ static void __exit booke_wdt_exit(void)
>  static int __init booke_wdt_init(void)
>  {
>         int ret = 0;
> -       bool nowayout = WATCHDOG_NOWAYOUT;
> 
>         pr_info("powerpc book-e watchdog driver loaded\n");
>         booke_wdt_info.firmware_version = cur_cpu_spec->pvr_value;
> 
> base-commit: dd0d718152e4c65b173070d48ea9dfc06894c3e5
> --
> 2.20.1
> 
> 
> 
> *Timothy Myers*
> Software Design Engineer
> 
> Office: 256.963.8844
> 
> ADTRAN
> 901 Explorer Boulevard 
> Huntsville, AL 35806 - USA