linux-kernel - Re: [PATCH 1/1] perf report TUI: Remove needless 'dummy' event from menu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM9d7chmV5itD-2K50qFcktJ2JPWdf=quDX_YL8HTYiHgzByXA@mail.gmail.com>
Date:   Tue, 7 Jul 2020 00:12:21 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:     Ian Rogers <irogers@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] perf report TUI: Remove needless 'dummy' event from menu

On Mon, Jul 6, 2020 at 8:55 PM Arnaldo Carvalho de Melo <acme@...hat.com> wrote:
>
> Em Fri, Jul 03, 2020 at 10:44:28PM +0900, Namhyung Kim escreveu:
> > > @@ -3613,7 +3630,7 @@ int perf_evlist__tui_browse_hists(struct evlist *evlist, const char *help,
> > >         int nr_entries = evlist->core.nr_entries;
> > >
> > >  single_entry:
> > > -       if (nr_entries == 1) {
> > > +       if (perf_evlist__single_entry(evlist)) {
> >
> > But I think it cannot cover the event group case below..
>
> Right, we can fix that later, I think, my worry at this point was that
> the simplest case, which is:
>
>    # perf record
>    ^C
>    # perf report
>
> Would get that annoyance :-)

Right, then I suggest moving the 'single_entry' label to inside of the
if statement.
With that applied,

Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks
Namhyung