linux-kernel - Re: [qemu] boot failed: Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2LmUVj-yhwxXeCpqdxqJpp0m-q9q9SKQpfh3tFgMXPQA@mail.gmail.com>
Date:   Mon, 6 Jul 2020 17:24:20 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Dave Jiang <dave.jiang@...el.com>
Cc:     Naresh Kamboju <naresh.kamboju@...aro.org>,
        linux-serial@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>,
        Vinod Koul <vkoul@...nel.org>, Jiri Slaby <jslaby@...e.com>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        linux-tegra <linux-tegra@...r.kernel.org>, jirislaby@...nel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        ldewangan@...dia.com, Thierry Reding <thierry.reding@...il.com>,
        Jon Hunter <jonathanh@...dia.com>, Qian Cai <cai@....pw>,
        lkft-triage@...ts.linaro.org
Subject: Re: [qemu] boot failed: Unable to handle kernel NULL pointer
 dereference at virtual address 0000000000000000

On Mon, Jul 6, 2020 at 5:01 PM Dave Jiang <dave.jiang@...el.com> wrote:
> On 7/6/2020 5:53 AM, Arnd Bergmann wrote:
> > On Mon, Jul 6, 2020 at 1:03 PM Naresh Kamboju <naresh.kamboju@...aro.org> wrote:
>
> Arnd,
> I'm looking at the pl001_dma_probe(), I think we could make it more robust if it
> uses IS_ERR_OR_NULL(chan) instead of IS_ERR(). Should I send a patch for it? I
> suppose looking at the comment header for dma_request_chan() it does say return
> chan ptr or error ptr. Sorry I missed that.

No. IS_ERR_OR_NULL() is almost always a mistake. A function should either
return NULL on error, or it should return an error code, but should not be
able to return either.

Have you checked all the other 'return NULL' statements in your patch to
ensure that they never return error pointers?

       Arnd