linux-kernel - Re: [PATCH 3/5] nvme-pci: Remove redundant segment validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR04MB49656927FC38696FDC8AB10286690@BYAPR04MB4965.namprd04.prod.outlook.com>
Date:   Mon, 6 Jul 2020 02:23:40 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Baolin Wang <baolin.wang@...ux.alibaba.com>,
        "kbusch@...nel.org" <kbusch@...nel.org>,
        "axboe@...com" <axboe@...com>, "hch@....de" <hch@....de>,
        "sagi@...mberg.me" <sagi@...mberg.me>
CC:     "baolin.wang7@...il.com" <baolin.wang7@...il.com>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/5] nvme-pci: Remove redundant segment validation

On 7/2/20 7:54 PM, Baolin Wang wrote:
> We've validated the segment counts before calling nvme_map_data(),
> so there is no need to validate again in nvme_pci_use_sgls() only
> called from nvme_map_data().
> 
> Signed-off-by: Baolin Wang<baolin.wang@...ux.alibaba.com>

Indeed we do call blk_rq_nr_phys_segments() in nvme_queue_rq().

Looks good to me.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>