lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 6 Jul 2020 10:58:15 -0500
From:   Bjorn Helgaas <>
To:     Rajat Jain <>
Cc:     David Woodhouse <>,
        Lu Baolu <>,
        Joerg Roedel <>,
        Bjorn Helgaas <>,
        "Rafael J. Wysocki" <>,
        Len Brown <>,,,,, Raj Ashok <>,,
        Mika Westerberg <>,
        Jean-Philippe Brucker <>,
        Prashant Malani <>,
        Benson Leung <>,
        Todd Broch <>,
        Alex Levin <>,
        Mattias Nissler <>,
        Rajat Jain <>,
        Bernie Keany <>,
        Aaron Durbin <>,
        Diego Rivas <>,
        Duncan Laurie <>,
        Furquan Shaikh <>,
        Jesse Barnes <>,
        Christian Kellner <>,
        Alex Williamson <>,
        Greg Kroah-Hartman <>,, Saravana Kannan <>,
        Suzuki K Poulose <>,
        Arnd Bergmann <>,
        Heikki Krogerus <>
Subject: Re: [PATCH v2 1/7] PCI: Keep the ACS capability offset in device

On Mon, Jun 29, 2020 at 09:49:37PM -0700, Rajat Jain wrote:
> Currently this is being looked up at a number of places. Read and store it
> once at bootup so that it can be used by all later.

Write the commit log so it is complete even without the subject.
Right now, you have to read the subject to know what "this" refers to.

The subject is like the title; the log is like the body of an article.
The title isn't *part* of the article, so the article has to make
sense all by itself.

> +static void pci_enable_acs(struct pci_dev *dev);

I don't think we need this forward declaration, do we?

> @@ -4653,7 +4653,7 @@ static int pci_quirk_intel_spt_pch_acs(struct pci_dev *dev, u16 acs_flags)
>  	if (!pci_quirk_intel_spt_pch_acs_match(dev))
>  		return -ENOTTY;
> -	pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ACS);
> +	pos = dev->acs_cap;

I assume you verified that all these quirks are FINAL quirks, since
pci_init_capabilities() is called after HEADER quirks.  I'll
double-check before applying this.


Powered by blists - more mailing lists