linux-kernel - Re: [PATCH v3 03/13] bus/fsl-mc: add support for 'driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2267de0c-0ee8-b277-4de8-0cc48fff14f5@oss.nxp.com>
Date:   Mon, 6 Jul 2020 19:35:50 +0300
From:   Diana Craciun OSS <diana.craciun@....nxp.com>
To:     Andrew Lunn <andrew@...n.ch>, Diana Craciun <diana.craciun@....com>
Cc:     linux-kernel@...r.kernel.org, laurentiu.tudor@....com,
        gregkh@...uxfoundation.org, stuyoder@...il.com, leoyang.li@....com,
        bharatb.linux@...il.com, Bharat Bhushan <Bharat.Bhushan@....com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 03/13] bus/fsl-mc: add support for 'driver_override' in
 the mc-bus

Hi Andrew,

I apologize, I somehow missed you previous comment.

OK, I see that there are a number of drivers using the same code. In 
case we share the code, probably we need to store the driver_override 
value in the struct device (not in the particular driver device 
structure as it is done now).

Diana


On 7/6/2020 4:57 PM, Andrew Lunn wrote:
> Hi Diana
>
> On Mon, Jul 06, 2020 at 03:42:33PM +0300, Diana Craciun wrote:
>> From: Bharat Bhushan <Bharat.Bhushan@....com>
>>
>> This patch is required for vfio-fsl-mc meta driver to successfully bind
>> layerscape container devices for device passthrough. This patch adds
>> a mechanism to allow a layerscape device to specify a driver rather than
>> a layerscape driver provide a device match.
>>
>> Example to allow a device (dprc.1) to specifically bind
>> with driver (vfio-fsl-mc):-
>>   - echo vfio-fsl-mc > /sys/bus/fsl-mc/devices/dprc.1/driver_override
>>   - echo dprc.1 > /sys/bus/fsl-mc/drivers/fsl_mc_dprc/unbind
>>   - echo dprc.1 > /sys/bus/fsl-mc/drivers/vfio-fsl-mc/bind
> Something i asked before, why is this buried in a driver, when it
> could be put in the driver core. This is not the only driver doing
> this, so it does make sense to share the code and bugs.
>
>        Andrew