linux-kernel - Re: [PATCH v2 26/30] misc: eeprom: at24: Tell the compiler that ACPI functions may not be used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Jul 2020 19:16:00 +0200
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg KH <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Wolfram Sang <wsa@...nel.org>,
        linux-i2c <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH v2 26/30] misc: eeprom: at24: Tell the compiler that ACPI
 functions may not be used

On Wed, Jul 1, 2020 at 11:36 AM Lee Jones <lee.jones@...aro.org> wrote:
>
> ... as is the case when !CONFIG_ACPI.
>
> Fixes the following W=1 kernel build warning:
>
>  drivers/misc/eeprom/at24.c:228:36: warning: ‘at24_acpi_ids’ defined but not used [-Wunused-const-variable=]
>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
> - Resending to add the I2C ML and Bartosz to the conversation
>   - Looks like I missed them when running get_maintainer.pl
> - This patch, like all the others in the set, should go in via Misc
>   - Although the patches are orthogonal, this makes life easier for Greg
>
>  drivers/misc/eeprom/at24.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
> index 9ff18d4961ceb..2591c21b2b5d8 100644
> --- a/drivers/misc/eeprom/at24.c
> +++ b/drivers/misc/eeprom/at24.c
> @@ -225,7 +225,7 @@ static const struct of_device_id at24_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, at24_of_match);
>
> -static const struct acpi_device_id at24_acpi_ids[] = {
> +static const struct acpi_device_id __maybe_unused at24_acpi_ids[] = {
>         { "INT3499",    (kernel_ulong_t)&at24_data_INT3499 },
>         { "TPF0001",    (kernel_ulong_t)&at24_data_24c1024 },
>         { /* END OF LIST */ }

Acked-by: Bartosz Golaszewski <bgolaszewski@...libre.com>

Please, drop the "Re:" prefix from the subject next time, I nearly
missed this in my inbox.

Thanks!
Bartosz