linux-kernel - Re: [PATCH v3 8/9] vfio/fsl-mc: trigger an interrupt via eventfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202007070207.UymIDlGr%lkp@intel.com>
Date:   Tue, 7 Jul 2020 02:53:36 +0800
From:   kernel test robot <lkp@...el.com>
To:     Diana Craciun <diana.craciun@....nxp.com>,
        alex.williamson@...hat.com, kvm@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        bharatb.linux@...il.com, linux-kernel@...r.kernel.org,
        laurentiu.tudor@....com, Diana Craciun <diana.craciun@....nxp.com>,
        Bharat Bhushan <Bharat.Bhushan@....com>
Subject: Re: [PATCH v3 8/9] vfio/fsl-mc: trigger an interrupt via eventfd

Hi Diana,

I love your patch! Perhaps something to improve:

[auto build test WARNING on vfio/next]
[also build test WARNING on linux/master linus/master v5.8-rc4 next-20200706]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Diana-Craciun/vfio-fsl-mc-VFIO-support-for-FSL-MC-devices/20200706-234519
base:   https://github.com/awilliam/linux-vfio.git next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project a378c0449507e00e96534ff9ce9034e185425182)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c:32:5: warning: no previous prototype for function 'vfio_fsl_mc_irqs_allocate' [-Wmissing-prototypes]
   int vfio_fsl_mc_irqs_allocate(struct vfio_fsl_mc_device *vdev)
       ^
   drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c:32:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int vfio_fsl_mc_irqs_allocate(struct vfio_fsl_mc_device *vdev)
   ^
   static 
   drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c:137:8: error: implicit declaration of function 'fsl_mc_populate_irq_pool' [-Werror,-Wimplicit-function-declaration]
           ret = fsl_mc_populate_irq_pool(mc_cont,
                 ^
   drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c:138:4: error: use of undeclared identifier 'FSL_MC_IRQ_POOL_MAX_TOTAL_IRQS'
                           FSL_MC_IRQ_POOL_MAX_TOTAL_IRQS);
                           ^
   1 warning and 2 errors generated.

vim +/vfio_fsl_mc_irqs_allocate +32 drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c

    31	
  > 32	int vfio_fsl_mc_irqs_allocate(struct vfio_fsl_mc_device *vdev)
    33	{
    34		struct fsl_mc_device *mc_dev = vdev->mc_dev;
    35		struct vfio_fsl_mc_irq *mc_irq;
    36		int irq_count;
    37		int ret, i;
    38	
    39	    /* Device does not support any interrupt */
    40		if (mc_dev->obj_desc.irq_count == 0)
    41			return 0;
    42	
    43		/* interrupts were already allocated for this device */
    44		if (vdev->mc_irqs)
    45			return 0;
    46	
    47		irq_count = mc_dev->obj_desc.irq_count;
    48	
    49		mc_irq = kcalloc(irq_count, sizeof(*mc_irq), GFP_KERNEL);
    50		if (!mc_irq)
    51			return -ENOMEM;
    52	
    53		/* Allocate IRQs */
    54		ret = fsl_mc_allocate_irqs(mc_dev);
    55		if (ret) {
    56			kfree(mc_irq);
    57			return ret;
    58		}
    59	
    60		for (i = 0; i < irq_count; i++) {
    61			mc_irq[i].count = 1;
    62			mc_irq[i].flags = VFIO_IRQ_INFO_EVENTFD;
    63		}
    64	
    65		vdev->mc_irqs = mc_irq;
    66	
    67		return 0;
    68	}
    69	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (74036 bytes)