linux-kernel - Re: [PATCH v2] drivers/net/wan/lapbether: Fixed the value of hard_header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200706.121636.148338846008093922.davem@davemloft.net>
Date:   Mon, 06 Jul 2020 12:16:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xie.he.0141@...il.com
Cc:     kuba@...nel.org, madhuparnabhowmik04@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-x25@...r.kernel.org
Subject: Re: [PATCH v2] drivers/net/wan/lapbether: Fixed the value of
 hard_header_len

From: Xie He <xie.he.0141@...il.com>
Date: Sun,  5 Jul 2020 17:45:21 -0700

> When this driver transmits data,
>   first this driver will remove a pseudo header of 1 byte,
>   then the lapb module will prepend the LAPB header of 2 or 3 bytes,
>   then this driver will prepend a length field of 2 bytes,
>   then the underlying Ethernet device will prepend its own header.
> 
> So, the header length required should be:
>   -1 + 3 + 2 + "the header length needed by the underlying device".
> 
> This patch fixes kernel panic when this driver is used with AF_PACKET
> SOCK_DGRAM sockets.
> 
> Signed-off-by: Xie He <xie.he.0141@...il.com>

Applied, thank you.