linux-kernel - 回复: [PATCH v3] usb: gadget: function: fix missing spinlock in f_uac1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Jul 2020 02:28:36 +0000
From:   "Zhang, Qiang" <Qiang.Zhang@...driver.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "balbi@...nel.org" <balbi@...nel.org>,
        "colin.king@...onical.com" <colin.king@...onical.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: 回复: [PATCH v3] usb: gadget: function: fix missing spinlock in f_uac1_legacy

Hi Greg KH
In the early submission:
"commit id c6994e6f067cf0fc4c6cca3d164018b1150916f8" which add USB Audio Gadget driver "   
the "audio->play_queue" was protected from "audio->lock"
spinlock in "playback_work" func, But in "f_audio_out_ep_complete" func 
there is no protection for the operation of this "audio->play_queue". there
are missing spinlock,  Fix tags should add up here commit？

________________________________________
发件人: Greg KH <gregkh@...uxfoundation.org>
发送时间: 2020年7月7日 3:55
收件人: Zhang, Qiang
抄送: balbi@...nel.org; colin.king@...onical.com; linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org; stable@...r.kernel.org
主题: Re: [PATCH v3] usb: gadget: function: fix missing spinlock in f_uac1_legacy

On Sun, Jul 05, 2020 at 08:40:27PM +0800, qiang.zhang@...driver.com wrote:
> From: Zhang Qiang <qiang.zhang@...driver.com>
>
> Add a missing spinlock protection for play_queue, because
> the play_queue may be destroyed when the "playback_work"
> work func and "f_audio_out_ep_complete" callback func
> operate this paly_queue at the same time.

"play_queue", right?

>
> Cc: stable <stable@...r.kernel.org>
> Signed-off-by: Zhang Qiang <qiang.zhang@...driver.com>

Because you do not have a Fixes: tag in here, how far back do you want
the stable patch to go to?  That's why, if you can, it's always good to
have a "Fixes:" tag in there to show what commit caused the problem you
are fixing here.

So, what commit caused this?

thanks,

gre gk-h