linux-kernel - Re: [PATCH V1 5/5] riscv: Add uprobes supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Jul 2020 23:28:57 +0800
From:   kernel test robot <lkp@...el.com>
To:     guoren@...nel.org, palmerdabbelt@...gle.com,
        paul.walmsley@...ive.com, anup@...infault.org,
        greentime.hu@...ive.com, zong.li@...ive.com, me@...ki.ch,
        bjorn.topel@...il.com, atish.patra@....com
Cc:     kbuild-all@...ts.01.org, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V1 5/5] riscv: Add uprobes supported

Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on v5.8-rc2]
[cannot apply to linus/master v5.8-rc3 next-20200707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/guoren-kernel-org/riscv-Add-k-uprobe-supported/20200704-113653
base:    48778464bb7d346b47157d21ffde2af6b2d39110
config: riscv-randconfig-s032-20200707 (attached as .config)
compiler: riscv32-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.2-31-gabbfd661-dirty
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)

   kernel/events/uprobes.c:1977:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct spinlock [usertype] *lock @@     got struct spinlock [noderef] __rcu * @@
   kernel/events/uprobes.c:1977:33: sparse:     expected struct spinlock [usertype] *lock
   kernel/events/uprobes.c:1977:33: sparse:     got struct spinlock [noderef] __rcu *
   kernel/events/uprobes.c:1979:35: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct spinlock [usertype] *lock @@     got struct spinlock [noderef] __rcu * @@
   kernel/events/uprobes.c:1979:35: sparse:     expected struct spinlock [usertype] *lock
   kernel/events/uprobes.c:1979:35: sparse:     got struct spinlock [noderef] __rcu *
   kernel/events/uprobes.c:2279:31: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct spinlock [usertype] *lock @@     got struct spinlock [noderef] __rcu * @@
   kernel/events/uprobes.c:2279:31: sparse:     expected struct spinlock [usertype] *lock
   kernel/events/uprobes.c:2279:31: sparse:     got struct spinlock [noderef] __rcu *
   kernel/events/uprobes.c:2281:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct spinlock [usertype] *lock @@     got struct spinlock [noderef] __rcu * @@
   kernel/events/uprobes.c:2281:33: sparse:     expected struct spinlock [usertype] *lock
   kernel/events/uprobes.c:2281:33: sparse:     got struct spinlock [noderef] __rcu *
>> include/asm-generic/mmiowb.h:56:9: sparse: sparse: context imbalance in '__replace_page' - unexpected unlock

vim +/__replace_page +56 include/asm-generic/mmiowb.h

d1be6a28b13ce6 Will Deacon 2019-02-22  46  
d1be6a28b13ce6 Will Deacon 2019-02-22  47  static inline void mmiowb_spin_unlock(void)
d1be6a28b13ce6 Will Deacon 2019-02-22  48  {
d1be6a28b13ce6 Will Deacon 2019-02-22  49  	struct mmiowb_state *ms = __mmiowb_state();
d1be6a28b13ce6 Will Deacon 2019-02-22  50  
d1be6a28b13ce6 Will Deacon 2019-02-22  51  	if (unlikely(ms->mmiowb_pending)) {
d1be6a28b13ce6 Will Deacon 2019-02-22  52  		ms->mmiowb_pending = 0;
d1be6a28b13ce6 Will Deacon 2019-02-22  53  		mmiowb();
d1be6a28b13ce6 Will Deacon 2019-02-22  54  	}
d1be6a28b13ce6 Will Deacon 2019-02-22  55  
d1be6a28b13ce6 Will Deacon 2019-02-22 @56  	ms->nesting_count--;

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (24543 bytes)