[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 7 Jul 2020 16:15:08 -0400
From: Peter Xu <peterx@...hat.com>
To: Sean Christopherson <sean.j.christopherson@...el.com>
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
"Dr . David Alan Gilbert" <dgilbert@...hat.com>,
Andrew Jones <drjones@...hat.com>,
Vitaly Kuznetsov <vkuznets@...hat.com>,
Paolo Bonzini <pbonzini@...hat.com>,
"Michael S . Tsirkin" <mst@...hat.com>,
Jason Wang <jasowang@...hat.com>,
Kevin Tian <kevin.tian@...el.com>
Subject: Re: [PATCH v10 02/14] KVM: Cache as_id in kvm_memory_slot
On Tue, Jul 07, 2020 at 12:56:58PM -0700, Sean Christopherson wrote:
> > > It's a single line of code, and there's more than one
> > > "shouldn't" in the above.
> >
> > If you want, I can both set it and add the comment. Thanks,
>
> Why bother with the comment? It'd be wrong in the sense that the as_id is
> always valid/accurate, even if npages == 0.
Sorry I'm confused.. when npages==0, why as_id field is meaningful? Even if
the id field is meaningless after the slot is successfully removed, or am I
wrong?
My understanding is that after your dynamic slot work, we'll only have at most
one extra memslot that was just removed, and that slot should be meaningless as
a whole. Feel free to correct me.
--
Peter Xu
Powered by blists - more mailing lists