linux-kernel - Re: [PATCH 8/9] usb: cdns3: Improvement: removed overwriting some error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Jul 2020 06:38:25 +0000
From:   Peter Chen <peter.chen@....com>
To:     Pawel Laszczak <pawell@...ence.com>
CC:     "balbi@...nel.org" <balbi@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "rogerq@...com" <rogerq@...com>,
        "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "colin.king@...onical.com" <colin.king@...onical.com>,
        "jpawar@...ence.com" <jpawar@...ence.com>,
        "ben.dooks@...ethink.co.uk" <ben.dooks@...ethink.co.uk>,
        "kurahul@...ence.com" <kurahul@...ence.com>,
        "sparmar@...ence.com" <sparmar@...ence.com>
Subject: Re: [PATCH 8/9] usb: cdns3: Improvement: removed overwriting some
 error code

On 20-07-01 08:20:03, Pawel Laszczak wrote:
> Some error code can be preserved, so we can remove overwriting
> error code returned by some functions.

Improve the patch title, otherwise:

Reviewed-by: Peter Chen <peter.chen@....com>

Peter
> 
> Signed-off-by: Pawel Laszczak <pawell@...ence.com>
> ---
>  drivers/usb/cdns3/core.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
> index 591186987245..01155ab73930 100644
> --- a/drivers/usb/cdns3/core.c
> +++ b/drivers/usb/cdns3/core.c
> @@ -347,7 +347,6 @@ static int cdns3_role_set(struct usb_role_switch *sw, enum usb_role role)
>  		case USB_ROLE_HOST:
>  			break;
>  		default:
> -			ret = -EPERM;
>  			goto pm_put;
>  		}
>  	}
> @@ -358,17 +357,14 @@ static int cdns3_role_set(struct usb_role_switch *sw, enum usb_role role)
>  		case USB_ROLE_DEVICE:
>  			break;
>  		default:
> -			ret = -EPERM;
>  			goto pm_put;
>  		}
>  	}
>  
>  	cdns3_role_stop(cdns);
>  	ret = cdns3_role_start(cdns, role);
> -	if (ret) {
> +	if (ret)
>  		dev_err(cdns->dev, "set role %d has failed\n", role);
> -		ret = -EPERM;
> -	}
>  
>  pm_put:
>  	pm_runtime_put_sync(cdns->dev);
> @@ -393,7 +389,7 @@ static int cdns3_probe(struct platform_device *pdev)
>  	ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
>  	if (ret) {
>  		dev_err(dev, "error setting dma mask: %d\n", ret);
> -		return -ENODEV;
> +		return ret;
>  	}
>  
>  	cdns = devm_kzalloc(dev, sizeof(*cdns), GFP_KERNEL);
> -- 
> 2.17.1
> 

-- 

Thanks,
Peter Chen