[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 7 Jul 2020 08:49:02 +0100
From: Lee Jones <lee.jones@...aro.org>
To: gregkh@...uxfoundation.org, linux-usb@...r.kernel.org
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Thomas Winischhofer <thomas@...ischhofer.net>
Subject: Re: [PATCH 04/30] usb: misc: sisusbvga: sisusb_init: Mark all
'static const' arrays as __maybe_unused
On Fri, 03 Jul 2020, Lee Jones wrote:
> drivers/usb/misc/sisusbvga/sisusb_init.h is included by a few
> source files. Most of which do not use the majority of the
> shared static const arrays which have been declared. This
> causes the build system to spew 100's of warnings.
>
> Fixes the following W=1 kernel build warning(s) - and a whole lot more:
>
> In file included from drivers/usb/misc/sisusbvga/sisusb.c:54:
> drivers/usb/misc/sisusbvga/sisusb_init.h:695:34: warning: ‘SiSUSB_VCLKData’ defined but not used [-Wunused-const-variable=]
> 695 | static const struct SiS_VCLKData SiSUSB_VCLKData[] = {
> | ^~~~~~~~~~~~~~~
> [10's of lines snipped]
> drivers/usb/misc/sisusbvga/sisusb_init.h:206:28: warning: ‘SiS_VGA_DAC’ defined but not used [-Wunused-const-variable=]
> 206 | static const unsigned char SiS_VGA_DAC[] = {
> | ^~~~~~~~~~~
> [10's of lines snipped]
> drivers/usb/misc/sisusbvga/sisusb_init.h:171:29: warning: ‘ModeIndex_1280x1024’ defined but not used [-Wunused-const-variable=]
> 171 | static const unsigned short ModeIndex_1280x1024[] = { 0x3a, 0x4d, 0x00, 0x65 };
> | ^~~~~~~~~~~~~~~~~~~
> [10's of lines snipped]
>
> Cc: Thomas Winischhofer <thomas@...ischhofer.net>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
> drivers/usb/misc/sisusbvga/sisusb_init.h | 66 ++++++++++++------------
> 1 file changed, 33 insertions(+), 33 deletions(-)
Greg,
Please drop this patch. I have a new solution.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists