linux-kernel - 回复: [PATCH v4] kthread: Work could not be queued when worker being destroyed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 7 Jul 2020 09:32:18 +0000
From:   "Zhang, Qiang" <Qiang.Zhang@...driver.com>
To:     Petr Mladek <pmladek@...e.com>
CC:     "ben.dooks@...ethink.co.uk" <ben.dooks@...ethink.co.uk>,
        "bfields@...hat.com" <bfields@...hat.com>,
        "cl@...k-chips.com" <cl@...k-chips.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "tj@...nel.org" <tj@...nel.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "naresh.kamboju@...aro.org" <naresh.kamboju@...aro.org>,
        "mm-commits@...r.kernel.org" <mm-commits@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 回复: [PATCH v4] kthread: Work could not be queued when worker being destroyed

Sorry,  Pter Mladek, this is my mistake please ignore this change.

________________________________________
发件人: linux-kernel-owner@...r.kernel.org <linux-kernel-owner@...r.kernel.org> 代表 Petr Mladek <pmladek@...e.com>
发送时间: 2020年7月7日 17:06
收件人: Zhang, Qiang
抄送: ben.dooks@...ethink.co.uk; bfields@...hat.com; cl@...k-chips.com; peterz@...radead.org; tj@...nel.org; akpm@...ux-foundation.org; naresh.kamboju@...aro.org; mm-commits@...r.kernel.org; linux-kernel@...r.kernel.org
主题: Re: [PATCH v4] kthread: Work could not be queued when worker being destroyed

On Mon 2020-07-06 13:46:47, qiang.zhang@...driver.com wrote:
> From: Zhang Qiang <qiang.zhang@...driver.com>
>
> Before the work is put into the queue of the worker thread,
> the state of the worker thread needs to be detected,because
> the worker thread may be in the destruction state at this time.
>
> Signed-off-by: Zhang Qiang <qiang.zhang@...driver.com>
> Suggested-by: Petr Mladek <pmladek@...e.com>
> Reviewed-by: Petr Mladek <pmladek@...e.com>

This patch is completely different from the one that I suggested
or acked. Please, never keep acks when doing major rework and
people did not agree with it.

For this patch:

Nacked-by: Petr Mladek <pmladek@...e.com>

See below why.


> ---
>  v1->v2:
>  Add warning information for condition "!worker->task".
>  v2->v3:
>  Modify submission information and add "Reviewed-by" tags.
>  v3->v4:
>  Fix spi controller register trigger Warning.
>  when a spi controller register, a "kthread_worker_fn" worker is created
>  through "kthread_run" instead of "kthread_create_worker" which in this
>  func the "worker->task" will be initialized. and then the "spi_start_queue"
>  func queue a work to worker queue, at this time, if the worker has not
>  begin to running, the "!worker->task" will be true, so a warning is triggered.
>
>  kernel/kthread.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/kernel/kthread.c b/kernel/kthread.c
> index bfbfa481be3a..825bd4dcdb95 100644
> --- a/kernel/kthread.c
> +++ b/kernel/kthread.c
> @@ -791,6 +791,11 @@ static inline bool queuing_blocked(struct kthread_worker *worker,
>  {
>       lockdep_assert_held(&worker->lock);
>
> +     if (kthread_should_stop()) {

This does not make much sense.

kthread_should_stop() checks a flag set for the "current" process.
It works only when called from inside the kthread worker thread.

queuing_blocked() is called from kthread_queue_work()
or kthread_queue_delayed_work(). These are typically
called from another process. The only exception is when
they get re-queued from inside the work.

Best Regards,
Petr


> +             WARN_ON(1);
> +             return true;
> +     }
> +
>       return !list_empty(&work->node) || work->canceling;
>  }
>
> --
> 2.24.1