linux-kernel - Re: [PATCH 24/28] ASoC: codecs: jz4770: Remove defined but never used variable 'mic_boost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 07 Jul 2020 12:40:16 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     broonie@...nel.org, lgirdwood@...il.com, perex@...ex.cz,
        tiwai@...e.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
        ter Huurne <maarten@...ewalker.org>
Subject: Re: [PATCH 24/28] ASoC: codecs: jz4770: Remove defined but never used
 variable 'mic_boost_tlv'

Hi,

Le mar. 7 juil. 2020 à 11:16, Lee Jones <lee.jones@...aro.org> a 
écrit :
> Fixes the following W=1 kernel build warning(s):
> 
>  In file included from include/sound/tlv.h:10,
>  from sound/soc/codecs/jz4770.c:19:
>  sound/soc/codecs/jz4770.c:306:35: warning: ‘mic_boost_tlv’ 
> defined but not used [-Wunused-const-variable=]
>  306 | static const DECLARE_TLV_DB_SCALE(mic_boost_tlv, 0, 400, 0);
>  | ^~~~~~~~~~~~~
>  include/uapi/sound/tlv.h:64:15: note: in definition of macro 
> ‘SNDRV_CTL_TLVD_DECLARE_DB_SCALE’
>  64 | unsigned int name[] = { | ^~~~
>  sound/soc/codecs/jz4770.c:306:14: note: in expansion of macro 
> ‘DECLARE_TLV_DB_SCALE’
>  306 | static const DECLARE_TLV_DB_SCALE(mic_boost_tlv, 0, 400, 0);
>  | ^~~~~~~~~~~~~~~~~~~~
> 
> Cc: Paul Cercueil <paul@...pouillou.net>
> Cc: ter Huurne <maarten@...ewalker.org>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Reviewed-by: Paul Cercueil <paul@...pouillou.net>

Cheers,
-Paul

> ---
>  sound/soc/codecs/jz4770.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/jz4770.c b/sound/soc/codecs/jz4770.c
> index 34775aa624024..4dee585761c24 100644
> --- a/sound/soc/codecs/jz4770.c
> +++ b/sound/soc/codecs/jz4770.c
> @@ -303,7 +303,6 @@ static int jz4770_codec_digital_mute(struct 
> snd_soc_dai *dai, int mute)
>  static const DECLARE_TLV_DB_MINMAX_MUTE(dac_tlv, -3100, 0);
>  static const DECLARE_TLV_DB_SCALE(adc_tlv, 0, 100, 0);
>  static const DECLARE_TLV_DB_MINMAX(out_tlv, -2500, 600);
> -static const DECLARE_TLV_DB_SCALE(mic_boost_tlv, 0, 400, 0);
>  static const DECLARE_TLV_DB_SCALE(linein_tlv, -2500, 100, 0);
> 
>  /* Unconditional controls. */
> --
> 2.25.1
>