linux-kernel - Re: [PATCH 1/1] ARM: dts: ux500: Supply nodes for the other 2 AB8500 PWM devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 7 Jul 2020 14:13:36 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Stephan Gerhold <stephan@...hold.net>
Subject: Re: [PATCH 1/1] ARM: dts: ux500: Supply nodes for the other 2 AB8500
 PWM devices

On Tue, Jul 7, 2020 at 2:11 PM Linus Walleij <linus.walleij@...aro.org> wrote:
> On Mon, Jun 22, 2020 at 10:34 AM Lee Jones <lee.jones@...aro.org> wrote:
>
> > As per 'struct mfd_cell ab8500_devs[]' there are not 1, but 3 PWM
> > devices on the AB8500.  Until now, each of them have referenced
> > the same Device Tree node.  This change ensures each device has
> > their own.
> >
> > Due to recent `dtc` checks [0], nodes cannot share the same node
> > name, so we are forced to rename the affected nodes by appending
> > their associated numeric 'bank ID'.
> >
> > [0] ste-ab8500.dtsi:210.16-214.7: ERROR (duplicate_node_names):
> >       /soc/prcmu@...57000/ab8500/ab8500-pwm: Duplicate node name
> >
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
>
> Patch applied!

BTW shouldn't we also patch ste-ab8505.dts?

Yours,
Linus Walleij