linux-kernel - Re: [PATCH] PCI: Replace kmalloc with kzalloc in the comment/message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200708152942.GA454574@bjorn-Precision-5520>
Date:   Wed, 8 Jul 2020 10:29:42 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     wang.yi59@....com.cn
Cc:     bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, xue.zhihong@....com.cn,
        wang.liang82@....com.cn, liao.pingfang@....com.cn
Subject: Re: [PATCH] PCI: Replace kmalloc with kzalloc in the comment/message

On Wed, Jul 08, 2020 at 05:22:09PM +0800, wang.yi59@....com.cn wrote:
> Hi Bjorn,
> 
> Thanks for your review and patience on the datails :)
> 
> > On Fri, May 29, 2020 at 09:01:59AM +0800, Yi Wang wrote:
> > > From: Liao Pingfang <liao.pingfang@....com.cn>
> > >
> > > Use kzalloc instead of kmalloc in the comment/message according to
> > > the previous kzalloc() call.
> > >
> > > Signed-off-by: Liao Pingfang <liao.pingfang@....com.cn>
> >
> > I would be happy to apply this, but this needs to show a connection
> > between Liao Pingfang and Yi Wang.
> >
> > Ideally this patch would be sent directly by Liao Pingfang.  The
> > sender should at least appear in the Signed-off-by chain.  See
> > Documentation/process/submitting-patches.rst
> 
> According to our company security policy, only a few people have
> access to send email outside of company, so this patch is sent by
> Yi Wang and the author is Liao Pingfang actually.

Please take a look at Documentation/process/submitting-patches.rst.
Specifically, it says:

  Notably, the last Signed-off-by: must always be that of the
  developer submitting the patch.

You are submitting the patch, but you didn't add a Signed-off-by.

Of course, adding your Signed-off-by means you are agreeing to the
"Developer's Certificate of Origin" (also in that file), which tells
me that the patch is licensed correctly and that you have the right to
submit it.

In addition, your signed-off-by means that if there are issues with
the patch, I will look to you (and Liao Pingfang, obviously) to help
resolve them.

So if that is all acceptable to you, just post this again with your
own signed-off-by below Liao Pingfang's.

Bjorn