linux-kernel - Re: [PATCH] Replace HTTP links with HTTPS ones: REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Jul 2020 13:53:36 -0500
From:   Suman Anna <s-anna@...com>
To:     "Alexander A. Klimov" <grandmaster@...klimov.de>,
        <ohad@...ery.com>, <bjorn.andersson@...aro.org>,
        <linux-remoteproc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: REMOTE PROCESSOR
 (REMOTEPROC) SUBSYSTEM

On 7/8/20 10:38 AM, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
> 
> Deterministic algorithm:
> For each file:
>    If not .svg:
>      For each line:
>        If doesn't contain `\bxmlns\b`:
>          For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> 	  If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
>              If both the HTTP and HTTPS versions
>              return 200 OK and serve the same content:
>                Replace HTTP with HTTPS.
> 
> Signed-off-by: Alexander A. Klimov <grandmaster@...klimov.de>

Suggest a revision of patch title to
"remoteproc: Replace HTTP links with HTTPS ones"

With that,
Acked-by: Suman Anna <s-anna@...com>

> ---
>   Continuing my work started at 93431e0607e5.
>   See also: git log --oneline '--author=Alexander A. Klimov <grandmaster@...klimov.de>' v5.7..master
>   (Actually letting a shell for loop submit all this stuff for me.)
> 
>   If there are any URLs to be removed completely or at least not HTTPSified:
>   Just clearly say so and I'll *undo my change*.
>   See also: https://lkml.org/lkml/2020/6/27/64
> 
>   If there are any valid, but yet not changed URLs:
>   See: https://lkml.org/lkml/2020/6/26/837
> 
>   If you apply the patch, please let me know.
> 
> 
>   drivers/remoteproc/da8xx_remoteproc.c    | 2 +-
>   drivers/remoteproc/keystone_remoteproc.c | 2 +-
>   drivers/remoteproc/omap_remoteproc.c     | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> index 98e0be9476a4..9a4938c3025f 100644
> --- a/drivers/remoteproc/da8xx_remoteproc.c
> +++ b/drivers/remoteproc/da8xx_remoteproc.c
> @@ -27,7 +27,7 @@ MODULE_PARM_DESC(da8xx_fw_name,
>   
>   /*
>    * OMAP-L138 Technical References:
> - * http://www.ti.com/product/omap-l138
> + * https://www.ti.com/product/omap-l138
>    */
>   #define SYSCFG_CHIPSIG0 BIT(0)
>   #define SYSCFG_CHIPSIG1 BIT(1)
> diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c
> index cd266163a65f..252ac6e2f653 100644
> --- a/drivers/remoteproc/keystone_remoteproc.c
> +++ b/drivers/remoteproc/keystone_remoteproc.c
> @@ -2,7 +2,7 @@
>   /*
>    * TI Keystone DSP remoteproc driver
>    *
> - * Copyright (C) 2015-2017 Texas Instruments Incorporated - http://www.ti.com/
> + * Copyright (C) 2015-2017 Texas Instruments Incorporated - https://www.ti.com/
>    */
>   
>   #include <linux/module.h>
> diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c
> index 6955fab0a78b..d191610454d9 100644
> --- a/drivers/remoteproc/omap_remoteproc.c
> +++ b/drivers/remoteproc/omap_remoteproc.c
> @@ -2,7 +2,7 @@
>   /*
>    * OMAP Remote Processor driver
>    *
> - * Copyright (C) 2011-2020 Texas Instruments Incorporated - http://www.ti.com/
> + * Copyright (C) 2011-2020 Texas Instruments Incorporated - https://www.ti.com/
>    * Copyright (C) 2011 Google, Inc.
>    *
>    * Ohad Ben-Cohen <ohad@...ery.com>
>