linux-kernel - Re: [PATCH][next] Bluetooth: Use fallthrough pseudo-keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <AA68478E-A46A-4914-BE62-3AC9989E358D@holtmann.org>
Date:   Wed, 8 Jul 2020 06:49:39 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-bluetooth <linux-bluetooth@...r.kernel.org>,
        kernel list <linux-kernel@...r.kernel.org>,
        netdev@...r.kernel.org
Subject: Re: [PATCH][next] Bluetooth: Use fallthrough pseudo-keyword

Hi Gustavo,

> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> fall-through markings when it is the case.
> 
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> 
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> ---
> drivers/bluetooth/bcm203x.c     |  2 +-
> drivers/bluetooth/bluecard_cs.c |  2 --
> drivers/bluetooth/hci_ll.c      |  2 +-
> drivers/bluetooth/hci_qca.c     |  8 +-------
> net/bluetooth/hci_event.c       |  4 ++--
> net/bluetooth/hci_sock.c        |  3 +--
> net/bluetooth/l2cap_core.c      | 19 +++++++++----------
> net/bluetooth/l2cap_sock.c      |  4 ++--
> net/bluetooth/mgmt.c            |  4 ++--
> net/bluetooth/rfcomm/core.c     |  2 +-
> net/bluetooth/rfcomm/sock.c     |  2 +-
> net/bluetooth/smp.c             |  2 +-
> 12 files changed, 22 insertions(+), 32 deletions(-)

can we split these a little bit between drivers, core and rfcomm. Thanks.

Regards

Marcel