linux-kernel - Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200708144900.058a8b25@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 8 Jul 2020 14:49:00 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Ooi, Joyce" <joyce.ooi@...el.com>
Cc:     Thor Thayer <thor.thayer@...ux.intel.com>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Dalon Westergreen <dalon.westergreen@...ux.intel.com>,
        Tan Ley Foon <ley.foon.tan@...el.com>,
        See Chin Liang <chin.liang.see@...el.com>,
        Dinh Nguyen <dinh.nguyen@...el.com>,
        Dalon Westergreen <dalon.westergreen@...el.com>
Subject: Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

On Wed,  8 Jul 2020 15:24:00 +0800 Ooi, Joyce wrote:
> +		/* get prefetcher rx poll frequency from device tree */
> +		if (of_property_read_u32(pdev->dev.of_node, "rx-poll-freq",
> +					 &priv->rx_poll_freq)) {
> +			dev_info(&pdev->dev, "Defaulting RX Poll Frequency to 128\n");
> +			priv->rx_poll_freq = 128;
> +		}
> +
> +		/* get prefetcher rx poll frequency from device tree */
> +		if (of_property_read_u32(pdev->dev.of_node, "tx-poll-freq",
> +					 &priv->tx_poll_freq)) {
> +			dev_info(&pdev->dev, "Defaulting TX Poll Frequency to 128\n");
> +			priv->tx_poll_freq = 128;
> +		}

I'm no device tree expert but these look like config options rather than
HW description. They also don't appear to be documented in the next
patch.