linux-kernel - Re: [PATCH net-next] bonding: don't need RTNL for ipsec helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200708.160925.601637997950999733.davem@davemloft.net>
Date:   Wed, 08 Jul 2020 16:09:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jarod@...hat.com
Cc:     linux-kernel@...r.kernel.org,
        syzbot+582c98032903dcc04816@...kaller.appspotmail.com,
        huyn@...lanox.com, saeedm@...lanox.com, j.vosburgh@...il.com,
        vfalico@...il.com, andy@...yhouse.net, jeffrey.t.kirsher@...el.com,
        kuba@...nel.org, steffen.klassert@...unet.com,
        herbert@...dor.apana.org.au, netdev@...r.kernel.org,
        intel-wired-lan@...ts.osuosl.org
Subject: Re: [PATCH net-next] bonding: don't need RTNL for ipsec helpers

From: Jarod Wilson <jarod@...hat.com>
Date: Wed,  8 Jul 2020 18:58:49 -0400

> The bond_ipsec_* helpers don't need RTNL, and can potentially get called
> without it being held, so switch from rtnl_dereference() to
> rcu_dereference() to access bond struct data.
> 
> Lightly tested with xfrm bonding, no problems found, should address the
> syzkaller bug referenced below.
> 
> Reported-by: syzbot+582c98032903dcc04816@...kaller.appspotmail.com
> Signed-off-by: Jarod Wilson <jarod@...hat.com>

Applied, thank you.